Add base version to common modules #12956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
rename-some-common-modules
branch
from
21cfd3d to
d73bd7a
Compare
trask
force-pushed
the
rename-some-common-modules
branch
from
d73bd7a to
2a00677
Compare
|
Closing, going to send a better overview for consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #932, I am thinking that it would be good to add base version to the "-common" modules as well (since we may end up with other "-common" modules in the future for other base versions).
This PR is just an example of a few. Will follow up with the rest if this sounds good.
Here's the full list: